feat: add support for Geth built-in tracers #1251

Wodann · 2025-12-30T00:05:01Z

This PR removes our custom EIP-3155 tracer and instead uses revm-inspector's DebugInspector. This brings us one step closer to unification of the tracing architecture, as we can use the same underlying inspector to generate our stack traces.

During testing, I discovered a bug in revm-inspectors. I was able to fix the bug and created a PR. After some back and forth, I'm waiting for the final approval. Until then, I decided to go ahead with a temporary dependency patch, using my fork of revm-inspectors. If desired, I can move the fork to the NomicFoundation organisation.

The hardhat-tests are using fixtures to validate that the generated output of debug_traceCall and debug_traceTransaction matches what Geth returns for specific requests. Unfortunately, the fixtures were old and no longer reflect the behaviour of the latest version of Geth. As such, I had to update the fixtures.

For future reference, I added instructions for how to generate new fixtures for future versions of Geth to each individual fixture. The instructions slightly differ per fixture as each fixture contains different JSON-RPC requests.

For fixtures that use "forking mode" I could not use Geth, since Geth does not support the concept of forking a blockchain. It can only fully sync to the live blockchain. To avoid a lot of time and storage to sync a node, I generated fixtures for "forking mode" by calling Alchemy. As Alchemy runs a mixture of clients (e.g. Erigon, Reth, and Geth), this does run a risk of hitting an Archive node that generates its JSON-RPC responses using Reth, which uses the same alloy dependency as us. I deemed this to be an acceptable trade-off to save a lot of time.

There is one outstanding issue. A previously disabled test can theoretically be re-enabled. However, I discovered a bug in REVM. I fixed the bug and created a PR. Once that's merged, I'll upgrade REVM and re-activate the test in a follow-up PR.

changeset-bot · 2025-12-30T00:05:04Z

🦋 Changeset detected

Latest commit: 7d64ffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nomicfoundation/edr	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

socket-security · 2025-12-31T07:02:27Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/hardhat@2.28.0

View full report

codecov · 2025-12-31T07:14:10Z

Codecov Report

❌ Patch coverage is 69.66292% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.10%. Comparing base (abc925b) to head (7d64ffc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/edr_provider/src/debug_trace.rs	58.62%	21 Missing and 3 partials ⚠️
crates/edr_provider/src/data.rs	90.47%	0 Missing and 2 partials ⚠️
crates/edr_provider/src/error.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   74.13%   74.10%   -0.03%     
==========================================
  Files         437      437              
  Lines       74716    74598     -118     
  Branches    74716    74598     -118     
==========================================
- Hits        55389    55282     -107     
+ Misses      17302    17285      -17     
- Partials     2025     2031       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR adds support for Geth built-in tracers by updating the Hardhat dependency from version 2.26.1 to 2.28.0 and implementing corresponding changes in the EDR codebase to handle debug tracing with Geth-compatible options.

Key Changes

Updates Hardhat to version 2.28.0 with patches to support Geth debug tracing
Replaces custom EIP-3155 tracer implementation with revm-inspectors DebugInspector
Updates test fixtures to match Geth 1.16.7 output format

Reviewed changes

Copilot reviewed 22 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
package.json	Updates Hardhat dependency from 2.26.1 to 2.28.0
pnpm-workspace.yaml	Adds "hardhat" to immediate install exceptions
patches/[email protected]	Adds patch file for Hardhat 2.28.0
patches/[email protected]	Removes obsolete patch for Hardhat 2.26.1
crates/edr_provider/src/debug_trace.rs	Replaces custom tracer with DebugInspector from revm-inspectors
crates/edr_provider/src/requests/debug.rs	Updates debug trace methods to use GethDebugTracingOptions
crates/edr_provider/Cargo.toml	Adds dependencies for alloy-rpc-types-trace and revm-inspectors
hardhat-tests/test/internal/hardhat-network/provider/utils/assertEqualTraces.ts	Simplifies trace comparison logic
hardhat-tests/test/fixture-debug-traces/*.ts	Updates test fixtures with Geth 1.16.7 traces

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hardhat-tests/test/fixture-debug-traces/elongatedMemoryRegressionTestTrace.ts

hardhat-tests/test/internal/hardhat-network/provider/modules/debug/traceTransaction.ts

Wodann · 2025-12-31T07:24:14Z

.changeset/tasty-ears-drive.md

+
+Our API is now aligned with Geth's tracing capabilities.
+
+BREAKING CHANGE: Memory capture used to be enabled by default on geth, but has since been flipped <https://github.com/ethereum/go-ethereum/pull/23558> and is now disabled by default. We have followed suit and disabled it by default as well. If you were relying on memory capture, you will need to explicitly enable it by setting the `enableMemory` option to `true` in your tracer configuration.


cc: @michalbrabec

Wodann · 2026-01-05T15:25:21Z

Lint error should be resolved by #1255

Wodann · 2026-01-05T17:32:42Z

hardhat-tests/test/internal/hardhat-network/stack-traces/compilers-list.ts

      viaIR: true,
    },
+  },
+  {


Motivation: To ensure that the stack trace tests keep succeeding, we need to add new solc compiler descriptions up until the version of Solidity that EDR reports as supporting.

Wodann · 2026-01-05T17:34:19Z

hardhat-tests/test/internal/hardhat-network/stack-traces/test.ts

 });

 describe("Solidity support", function () {
-  it("check that the latest tested version is within the supported version range", async function () {


Motivation: When these tests lived in Hardhat, it made sense to ensure that there was a test to validate that the latest test version and the SUPPORTED_SOLIDITY_VERSION_RANGE matched.

Since these tests now live in EDR, there is no need to check that. We only need to ensure that we test all solc versions up until the one reported by EDR (latestSupportedSolidityVersion)

Wodann · 2026-01-05T17:35:00Z

hardhat-tests/test/internal/hardhat-network/stack-traces/test.ts

  it("check that the latest tested version matches the one that EDR exports", async function () {
    const latestSupportedVersion = getLatestTestedSolcVersion();
-    const edrLatestSupportedVersion = getLatestSupportedSolcVersion();
+    const edrLatestSupportedVersion = latestSupportedSolidityVersion();


Motivation: I replaced the previously hardcoded value from getLatestSupportedSolcVersion with the dynamic value in latestSupportedSolidityVersion that reports the latest supported Solidity version of Slang.

Wodann · 2026-01-05T17:35:32Z

hardhat-tests/package.json

    "ethers": "^6.1.0",
    "fs-extra": "^7.0.1",
-    "hardhat": "2.26.1",
+    "hardhat": "2.28.0",


Note: The upgrade of Hardhat to 2.28.0 brought to light issues with the stack trace tests

anaPerezGhiglia · 2026-01-05T19:20:21Z

crates/edr_provider/src/debug_trace.rs

-use std::{collections::HashMap, fmt::Debug};
+use std::fmt::Debug;

+use alloy_rpc_types_trace::geth::{GethDebugTracingOptions, GethTrace};


should we re-export these types and rename them to DebugTracingOptions and Trace to avoid filling our code with references to geth?

I'm happy to. I'm fine either way.

It signals that it matches the format defined by Geth, which we consciously follow. We can also rename it to something generic though. Would you like me to change it?

whatever you feel best. It was just to bring it up in case you hadn't considered it

crates/edr_provider/src/requests/methods.rs

anaPerezGhiglia

LGTM

Wodann self-assigned this Dec 30, 2025

This was linked to issues Dec 30, 2025

Support standard prestateTracer #1091

Open

supporting callTracer in debug_traceTransaction #392

Open

Wodann added 5 commits December 31, 2025 06:50

WIP: feat: add support for Geth built-in tracers

a2d4dd4

WIP: feat: debug_* JSON-RPC

15224cd

feat: add support for Geth built-in tracers

dc90950

test: fix fork tests

4a05277

fix: merge conflict

b1caf09

Wodann force-pushed the feat/geth-debugger branch from 703348d to b1caf09 Compare December 31, 2025 07:01

Wodann temporarily deployed to github-action-benchmark December 31, 2025 07:02 — with GitHub Actions Inactive

Wodann temporarily deployed to github-action-benchmark December 31, 2025 07:06 — with GitHub Actions Inactive

Wodann had a problem deploying to github-action-benchmark December 31, 2025 07:06 — with GitHub Actions Error

Wodann requested a review from Copilot December 31, 2025 07:14

Wodann requested a review from a team December 31, 2025 07:14

Wodann marked this pull request as ready for review December 31, 2025 07:14

Copilot AI reviewed Dec 31, 2025

View reviewed changes

hardhat-tests/test/fixture-debug-traces/elongatedMemoryRegressionTestTrace.ts Show resolved Hide resolved

hardhat-tests/test/internal/hardhat-network/provider/modules/debug/traceTransaction.ts Show resolved Hide resolved

misc: add changeset

ee85ee1

Wodann temporarily deployed to github-action-benchmark December 31, 2025 07:22 — with GitHub Actions Inactive

Wodann commented Dec 31, 2025

View reviewed changes

Wodann temporarily deployed to github-action-benchmark December 31, 2025 07:26 — with GitHub Actions Inactive

Wodann had a problem deploying to github-action-benchmark December 31, 2025 07:26 — with GitHub Actions Failure

fix: remove and update Stack trace tests

656106a

Wodann requested a deployment to github-action-benchmark January 5, 2026 17:29 — with GitHub Actions In progress

doc: add comment explaining how to obtain new solc versions

3d51e7a

Wodann temporarily deployed to github-action-benchmark January 5, 2026 17:32 — with GitHub Actions Inactive

Wodann commented Jan 5, 2026

View reviewed changes

Wodann had a problem deploying to github-action-benchmark January 5, 2026 17:54 — with GitHub Actions Failure

Wodann temporarily deployed to github-action-benchmark January 5, 2026 17:54 — with GitHub Actions Inactive

anaPerezGhiglia reviewed Jan 5, 2026

View reviewed changes

Merge branch 'main' into feat/geth-debugger

6cd9da7

Wodann temporarily deployed to github-action-benchmark January 8, 2026 15:28 — with GitHub Actions Inactive

Wodann requested a review from anaPerezGhiglia January 8, 2026 15:31

Wodann had a problem deploying to github-action-benchmark January 8, 2026 15:33 — with GitHub Actions Error

fix: prettier

f086f04

Wodann had a problem deploying to github-action-benchmark January 8, 2026 15:35 — with GitHub Actions Error

misc: add changeset

de38b74

Wodann temporarily deployed to github-action-benchmark January 8, 2026 15:37 — with GitHub Actions Inactive

Wodann had a problem deploying to github-action-benchmark January 8, 2026 15:39 — with GitHub Actions Failure

Wodann temporarily deployed to github-action-benchmark January 8, 2026 15:39 — with GitHub Actions Inactive

anaPerezGhiglia approved these changes Jan 8, 2026

View reviewed changes

fix: merge conflict

7cb8c73

Wodann had a problem deploying to github-action-benchmark January 8, 2026 16:53 — with GitHub Actions Error

Merge branch 'main' into feat/geth-debugger

e8838a9

Wodann temporarily deployed to github-action-benchmark January 8, 2026 16:54 — with GitHub Actions Inactive

Wodann had a problem deploying to github-action-benchmark January 8, 2026 17:03 — with GitHub Actions Failure

Wodann temporarily deployed to github-action-benchmark January 8, 2026 17:03 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/main' into feat/geth-debugger

7d64ffc

Wodann temporarily deployed to github-action-benchmark January 30, 2026 21:24 — with GitHub Actions Inactive

Wodann temporarily deployed to github-action-benchmark January 30, 2026 21:47 — with GitHub Actions Inactive

Wodann had a problem deploying to github-action-benchmark January 30, 2026 21:47 — with GitHub Actions Failure


		Our API is now aligned with Geth's tracing capabilities.

		BREAKING CHANGE: Memory capture used to be enabled by default on geth, but has since been flipped <https://github.com/ethereum/go-ethereum/pull/23558> and is now disabled by default. We have followed suit and disabled it by default as well. If you were relying on memory capture, you will need to explicitly enable it by setting the `enableMemory` option to `true` in your tracer configuration.

feat: add support for Geth built-in tracers #1251

Are you sure you want to change the base?

feat: add support for Geth built-in tracers #1251

Uh oh!

Conversation

Wodann commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

socket-security bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Wodann Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Wodann commented Jan 5, 2026

Uh oh!

Wodann Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Wodann Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Wodann Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Wodann Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anaPerezGhiglia Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Wodann Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

anaPerezGhiglia Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anaPerezGhiglia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wodann commented Dec 30, 2025 •

edited

Loading

changeset-bot bot commented Dec 30, 2025 •

edited

Loading

socket-security bot commented Dec 31, 2025 •

edited

Loading

codecov bot commented Dec 31, 2025 •

edited

Loading

Wodann Jan 5, 2026 •

edited

Loading